[Bug fix] Make "Mapping" configuration field optional #559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue: #531
The solution that the poster suggested worked properly. I looked through the mapper_module to be sure and indeed all the yaml params are accessed with default values (i.e. if they arent in the yaml node, a default value is assigned).
To be certain, I also created a modified version of aist/equirectangular.yaml wherein I removed the
Mapping:
node entirely and from the yaml file and ran the aist_entrance_hall_1 equirectangular sequence. It worked as expected. here's the console output to verify this: